CloseNotify() is deprecated

Open perpetual-hydrofoil opened this issue 6 years ago • 1 comments

Unfortunately, CloseNotify() is deprecated:

"Deprecated: the CloseNotifier interface predates Go's context package. New code should use Request.Context instead." (https://golang.org/pkg/net/http/#CloseNotifier)

Jul 23 '19 00:07 perpetual-hydrofoil

(Why this matters: it makes eventsource incompatible with most newer plugins/middleware that use context or that wrap the ResponseWriter like loggers, routers like fasthttp routers, etc.)

Jul 23 '19 16:07 perpetual-hydrofoil