Dominik Krejcik comments

Results 10 comments of


                                            Dominik Krejcik

fix(express): dont lose route if preceded by middleware with longer path

I don't know if there is a *reliable* way to detect which middleware was the handler, but there are some workarounds we could add. Specifically I think this bug can...

fix(express): dont lose route if preceded by middleware with longer path

Updated the PR to look for a regex instead, what do you think now?

fix(express): dont lose route if preceded by middleware with longer path

> I don't know about ignoring regexes completely Is the current implementation ignoring regexes completely? Sorry I'm not entirely clear on what will happen in all the cases. Can you...

fix(express): dont lose route if preceded by middleware with longer path

So I updated it again - I think what we're trying to do is get the _most specific_ route in the stack. Now the logic is this: * If the...

fix(express): dont lose route if preceded by middleware with longer path

@rochdev have you had a chance to look at the latest updated version? (Btw we've been running this in production for 25 days without any issues)

fix(express): dont lose route if preceded by middleware with longer path

Thanks @rochdev > I'm a bit worried about performance, but since it's isolated to regular expressions it might be good enough for most cases. Is there a way we can...

fix(express): dont lose route if preceded by middleware with longer path

@rochdev is there anything I can help with to get this merged?

fix(express): dont lose route if preceded by middleware with longer path

Thanks for the suggestion @rochdev - updated the PR with your logic.

fix(express): dont lose route if preceded by middleware with longer path

@rochdev have you had a chance to review this please?

fix(express): dont lose route if preceded by middleware with longer path

Bumping :) this patch is still relevant and cleanly applies on top of v3.11.0