Dominik Deren

Hey @serain, Cool that would be great! I’m also happy to contribute if you are accepting contributions to the API as well. By the way, could you tell how is...

So I have ran SlimerJS in debug mode with and without Docker. The command I used when I ran it without Docker was: ``` bash ./slimerjs --debug=yes --webdriver 0.0.0.0:8081 –error-log-file=/tmp/slimer-error.log...

I've re-ran it with: ``` bash ./slimerjs --debug=yes --webdriver 127.0.0.1:8081 –error-log-file=/tmp/slimer-error.log --webdriver-logfile /tmp/webdriver.log --webdriver-loglevel DEBUG ``` Got log: ``` 2016-05-05T20:51:10.328Z [DEBUG] Gecko version: 40.0.3 2016-05-05T20:51:10.328Z [DEBUG] script args: file:///Users/dominik/Downloads/slimerjs-1.0.0-pre/vendors/ghostdriver/main.js –error-log-file=/tmp/slimer-error.log...

Hey @wallyqs it would be great to hear your thoughts on this PR.

Hey @tothandras thanks for your comments. I'm on holidays at the moment, but will look into it once I'm back in ~2 weeks.

Hey @tothandras I updated this PR with your comments. I think I included them all, but would you mind taking a look?

Hey I think the rebase should be done, though I'm not sure if I didn't mess something up... Looks like a lot of changes now...

Hey @wallyqs thanks for the help! I followed your steps and force pushed just those changes that looked like my original implementation. It should make it easier to review. Let's...

@tothandras I think I tried to take this implementation of __sanitize_name from the golang implementation. Are they different now?

Hmm there are two tests failing, but those are two different tests in two different builds, both don't seem to be related to my changes... Should I expect some flakiness...