Colin Smith comments

Results 10 comments of


                                            Colin Smith

I think that is a reasonable proposal @stsewd. I have not yet tried to do any customization with the footer API, but I can look at that more.

Thanks @humitos. On first review, this looks like a good solution. I will pass this on to our doc team.

Closing this as the contribution has been merged

We have received feedback and will make an internal decision on caching.

@stanleytsang-amd will follow up with @eidenyoshida to see if we can enable the HMM tests now.

We now have some CI jobs enabled internally for basic tests. There is still some work to enable all test jobs and have results reported back on PRs.

@fluidnumerics-joe Thanks for submitting the patch! We are testing it internally and will update when testing is complete.

@cgmb to follow up on the merge conflict

@rigtorp Thank you for reporting the issue. There is a fix planned for an upcoming release of rocPRIM

We think this may be fixed in pytorch and therefore not require any change to rocPRIM. @stanleytsang-amd will confirm.