Matthias Oertel

[CLI] Review exit code behaviour of CLI commands

4

Migrate status still returns a 0 exit code even though a clearly defined error is returned (P1000 failed to connect to db in my case). We should change the code...

We are already offering Code Actions to ease the renaming of schema entities. eg. Renaming a Model from `Post` to `PrivatePost` will change it in the relations it is used...

Offer correct Prisma type when detecting a mismatch between Prisma type and native type.

1

We already detect when the Prisma type is incompatible with the specified native type. e.g. on Postgres `string_column String @db.BigInt` would show a validation error. A quick fix to convert...

Non-allocating trim method

7

Hey, thanks for the library. When I was using it I saw that a lot of time was spent in the trim method and stumbled over the comment about making...

While fixing a relation filter bug I had to look at way too many of our generated SQL statements. I think there is potential for optimization / cleanup. We should...

Look into exposing warnings from datamodel parsing

1

Concrete example: having @id and @unique on the same field is unnecessary, but on most dbs still valid. We could warn users about this. But we should maybe also think...

Add more testing for dbgenerated that introspects and deploys

1

Make sure that we introspect default values that end up in dbgenerated in a way that results in valid AND equivalent DDL when using the datamodel with migrate. MySql example...

Move logic ensuring valid DDL out of the Renderers into the datamodel validation during parsing

2

Example from the MySql renderer ``` let default_str = column .default() .filter(|default| { !matches!(default.kind(), DefaultKind::Sequence(_)) // We do not want to render JSON defaults because they are not supported by...

Discard Connection after aborted Transaction

1

Here we introduced a transaction around DDL operations in order to abort invalid enum migrations. https://github.com/prisma/prisma-engines/pull/1016 When the transaction fails without an explicit rollback being submitted next, the following statement...