Daniele Martinoli

Results 78 comments of Daniele Martinoli

Hi all, I can take a look at this issue, as agreed with @jeremyary FYI, I've just started playing with the latest ruff(*), which uses flake8 6.1.0 instead of Feast...

One more point: ATM Feast uses `mypy, isort, flake8 and black` in the `lint-python` step of the CI, but `mypy` [is not covered by ruff](https://docs.astral.sh/ruff/faq/#how-does-ruffs-linter-compare-to-pylint): > It's recommended that you...

Hi, another thing I've just discovered and then I'll stop bothering until you provide any guidance. The current configuration enables error code `C`, but also ignores error `C901`, e.g. the...

A possible configuration to replicate the current linter behavior (note: it must be in `pyproject.toml` because `setyp.cfg` is not supported): ``` [tool.ruff] exclude = [".git","__pycache__","docs/conf.py","dist","feast/protos","feast/embedded_go/lib","feast/infra/utils/snowflake/snowpark/snowflake_udfs.py"] [tool.ruff.lint] select = ["E","F","W","I"] ignore...

As agreed with @jeremyary , sent PR https://github.com/feast-dev/feast/pull/4043 to clarify what I tried to explain in previous comments.

@tokoko can you confirm the above assumptions, in order to guide @lokeshrangineni 's implementation?

@tokoko we started thinking about a possible solution, that we can share after completing the internal review, but first we'd like to ask a few questions to verify our understanding...

> Maybe, I'm not sure what that would look like though. Do you mean listing defined roles or permissions that can be specified in those roles? Yep, something like ```...

> ...manipulating objects in feast registry: Entity, DataSource, FeatureView, StreamFeatureView, OnDemandFeatureView, FeatureService, SavedDataset, ValidationReference. (TAL at registry server [proto](https://github.com/feast-dev/feast/blob/master/protos/feast/registry/RegistryServer.proto) for reference) So you mean the [FeastObjectType](https://vscode.dev/github/dmartinol/feast/blob/remote_offline/sdk/python/feast/infra/registry/registry.py#L70) enum (to be extended...

> Yes, that sounds about right. not sure what you mean about Registry type, can you elaborate? When a user runs feast apply it almost exclusively boils down to crud...