David L. Qiu

Results 257 comments of David L. Qiu

I am unable to reproduce this error. Inline math with the '>' renders properly on my machine. This issue should probably be closed because it is stale and no longer...

Reproducible in the `circleci/node:latest-browsers` Docker image. Specifically, the error I receive is this: ``` Application launch 1) "before each" hook for "shows an initial window" 0 passing (1s) 1 failing...

Same issue. Running on CircleCI's `circleci/node:latest-browser` Docker image, ships w/ Node v14.6.0 and Chromium 83.0. Absolutely no idea how to resolve this. I've passed all the above flags to Chromium,...

@Zsailer Hey Zach! Thank you for taking the time to review my progress so far. Right now, I'm working on implementing handling for out-of-band file system operations along with a...

Hey @kevin-bates! Thanks for the review. You can make some excellent points. However, I literally was just about to push my latest changes on top of this PR. I'll do...

I'm pushing my latest changes (which track out-of-band filesystem operations) now. EDIT: oh geez, the commit history is weirdly interweaved with review comments. yikes. LMK if you all want me...

@kevin-bates Thank you for your suggestions! I addressed as many as I could, but I believe it's best if I start working on separating my work into a standalone server...

Hey team! This is now migrated into a separate server extension: https://github.com/jupyter-server/jupyter_server_fileid Thank you all for your review comments! I've left open review questions as issues on that repo.

Looks good! The changes are pretty lean, so I say we can just merge this after the pipeline passes. Took a quick look at the failing tests here: https://github.com/jupyter-server/jupyter_server/runs/8020778443?check_suite_focus=true. It...

@Zsailer BTW, have we established a convention for where to place event schemas within the `jupyter_server` project? I was thinking just under `/jupyter_server/schemas`. Could you also paste the Contents Manager...