Daniel Pierce
Daniel Pierce
Hyrax 3 on Ruby 2.5 with BE 1.2.0 fails CI with: ``` 1: from /usr/local/bundle/gems/browse-everything-1.2.0/lib/browse_everything.rb:58:in `configure' /usr/local/lib/ruby/2.5.0/psych.rb:313:in `safe_load': unknown keyword: permitted_classes (ArgumentError) ``` Could add `required_ruby_version` to the gemspec?
When BrowseEverything::Retriever#get_file_size sends a HEAD request to an S3 service it uses the same signed url that a GET request would use. This results in a 403 response because the...
Attempting to use version 4 of the psych gem results in this error due to safe_load dropping the old deprecated method signature. ``` ArgumentError: wrong number of arguments (given 4,...
``` Bundler could not find compatible versions for gem "faraday": In Gemfile: hyrax (~> 2.9.6) was resolved to 2.9.6, which depends on active-fedora (>= 11.5.2, < 13) was resolved to...
Hyrax 5 feels ready for release, this should be the last rc before 5 is out for real (next week?!). @samvera/hyrax-code-reviewers
### Descriptive summary In valkyrie/fedora ID are not in a pair tree like `http://localhost:8081/fcrepo/rest/development/21/92/c0/41/2192c041-f600-4ab2-8027-bd6b568229ec` ### Actual behavior (include screenshots if available) In Valkyrie/Fedora (Sirenia) object URIs are like `http://fcrepo:8080/fcrepo/rest/development/2192c041-f600-4ab2-8027-bd6b568229ec` without...
### Descriptive summary `spec/views/hyrax/collections/_show_document_list_row.html.erb_spec.rb` fails in koppie with: ``` Failure/Error: mock_model(GenericWork, label: 'One Hundred Years of Solitude', date_uploaded: '1999', collection?: true, visibility: 'open', title: ['One Hundred Years of Solitude'], depositor:...
### Descriptive summary `spec/features/delete_work_spec.rb` and `spec/controllers/hyrax/fixity_checks_controller_spec.rb` fail in koppie with: ``` Failure/Error: fs.apply_depositor_metadata evaluator.user.user_key NoMethodError: undefined method `apply_depositor_metadata' for # ./spec/factories/file_sets.rb:9:in `block (3 levels) in ' ``` This should use...
### Changes proposed in this pull request: * Remove deprecated `Hyrax::SolrQueryBuilderService` * Migrate a few remaining uses of the service @samvera/hyrax-code-reviewers