Dimitri Lesnoff comments

Results 73 comments of


                                            Dimitri Lesnoff

Here's a list of 7 typos and formatting problems I found in the book. (I finished reading it a couple days ago.)

Just one another typo p.14 : "If we use two points **do** define a line" -> **to**

Might this repository works for nim v1.6.0 ?

v1.2.6 branch. Some files fails to compile. Exceptions changed. I may try to remove warnings and hints too, if I have time. A new branch would be great !

Document Nim data structure layout

I am really looking forward to it. The documentation @shirleyquirk has written is a great beginning, but I would like to understand more the internals. Maybe we can add urls...

Remove deprecated ident type, getNum -> getInt

Actually no, I have done testing with 1.2.6, I get the same warnings (deprecated since 0.18.1 !) and the same getNum error. Obviously, I got same error and warnings with...

Remove deprecated ident type, getNum -> getInt

I get one error because getNum() does not exist in the json library

implement container blocks

> Everything else I haven't thought of... Update allblocks.nim in docsrc to document the new block!

Sequence code on Page 42 unable to compile

Before nim 1.4.0 (not sure of the exact version), the operator was `..` and `

[Feature Request] Random BigInt

I am not sure we can call this fuzzing, that is why I purposely avoided the term. Even though my inputs to my tests are random, I just want to...

[Feature Request] Implement fast multiplication (Karatsuba, Tom-Cook, FFT)

I have written a function : `func unsignedKaratsubaMultiplication(a: var BigInt, b, c: BigInt) {.inline.} =` But I am unsure how to handle certain cases of the algorithm. I have written...

[Feature Request] Implement fast multiplication (Karatsuba, Tom-Cook, FFT)

I have found [this reference](https://cel.archives-ouvertes.fr/cel-01500109/document) by Richard P.Brent & P. Zimmerman (arithmetic researchers that helped to develop GMP) which describe a little more precisely karatsuba, the subtractive variant (variant that...