Dave Smith
Dave Smith
@rsevero , if it makes you feel any better, I've been using Catch2 v2 with single header file for years, and I struggled for hours to get Catch2 v3 working...
> Is it possible to initialize all members in the constructor, or is there some logic that prevents this? @carlocorradini Do you mean in general terms, or do you have...
I think this is the next step needed in the path towards enum classes as I suggested here: https://github.com/karljj1/kdis/pull/50#issuecomment-2605855669
@karljj1 @carlocorradini Can either of you explain the intent of this confusing behavior? I've also seen this pattern elsewhere in the code, so I'm guessing there's a reason for it?...
Thanks, @karljj1. This part of the standard has not changed as of the latest version I could find, [SISO-REF-010 V33 (Enumerations)](https://www.sisostandards.org/news/678685/Publication-of-SISO-REF-010-V33-Enumerations.htm), published July 30, 2024.
I'm attaching my suggested patch. I couldn't figure out how to push my branch to Github, since I didn't know how to fork the graaf.wiki repo in the normal Github...
This is supported by C++ Core Guidelines [[Enum.3](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#enum3-prefer-class-enums-over-plain-enums)]. Would need to avoid breaking existing clients. Suggest the following approach, hat tip Grok for guiding ideas here. Leave old code untouched,...
Tackle `-Winconsistent-missing-override` warnings first, there are very many of these. Follow the C++ Core Guidelines' [C.128](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c128-virtual-functions-should-specify-exactly-one-of-virtual-override-or-final).
@carlocorradini for my initial work on this issue, I looked at the latest build on #64, and noticed that [check / Build (macos-latest, Release, 5, OFF) (pull_request)](https://github.com/karljj1/kdis/actions/runs/13741309355/job/38430893938?pr=64) (as just one...
Here's a representative example of the type of assessments I've been making to eliminate `-Winconsistent-missing-override` warnings.