Daniel K. O. comments

Repositories
Issues
Comments

Results 3 comments of


                                            Daniel K. O.

Broken pkg-config Libs.private OpenGL libraries with MinGW cross compilation.

No, it would also be wrong to have `-l` in front of absolute paths. I just checked the MSYS2 SFML package (https://packages.msys2.org/base/mingw-w64-sfml), it's also broken, for both MinGW and Clang...

Broken pkg-config Libs.private OpenGL libraries with MinGW cross compilation.

OpenGL detection is already working for building SFML, right? So all you need is a dedicated variable for the pkg-config scripts, where you hardcode the result for Windows builds, instead...

Consider using `std::shared_ptr` to improve object lifetime safety

I like the `lifetimes` branch. Keeping both versions seems like the best compromise. My suggestions: - For every relevant type `Foo`, make a **public** type alias `FooPtr` for `std::shared_ptr`, or...