Divin OA
Divin OA
> Can you please run `clang-format`? Basically let's get past the superficial bits before we can dig into the threading. Thank you for checking. I have run clang-format on my...
Sorry for the inconvenience one header file was missed out from formatting. I have corrected that as well. Hopefully this solves all the formatting issues from my changeset.
> So, lots of comments. Make sure you read them all first, because some will make the other ones perhaps not needed. In particular, the propsed change to lcfs_node_set_from_content() will...
> Various nitpicks, but overall this looks good to me. Thank you for reviewing it. I have addressed those and pushed the changes.
> Also, if you're able to talk about it, I'd love to hear what you're using composefs for. Its good to know what your users are doing. Can you give...
> left a comment, could you please sign the commits with your real name? My real name is Divin and i have signed off the commits with it. Did you...
> Yes, separate PRs for things like this that are logically separate please. I will create a separate PR for it. Can i also squash up the current commits in...
> Yes, I think one or two commits here is best. Squashed the commits to just 2 (one for library and one for mkcomposefs) and siged it off with my...
> I'm assuming your goal is faster `mkcomposefs` overall (on a server side build system, right?). Using multiple threads is one way to do that. However, another way is caching...