Divij Vaidya

KAFKA-13133: Replace EasyMock and PowerMock with Mockito for AbstractHerderTest

3

This PR is created on top of abandoned PR https://github.com/apache/kafka/pull/11137. I have added the previous author's comment in this PR for attribution. I have also addressed the pending comments from...

Two changes in this PR. 1. Remove synchronized block and simplify it by using a latch. 2. Do not ignore the return value for `CoreUtils.registerMBean`. Since the method does not...

KAFKA-13950: Fix resource leaks

3

# Problem We are not properly closing Closeable resources in the code base at multiple places. # Change This code change fixes multiple of these leaks. Note that 1. `UncheckedIOException`...

MINOR: Include the inner exception stack trace when re-throwing an exception

6

# Problem: While wrapping the caught exception into a custom one, information about the caught exception is being lost, including information about the stack trace of the exception. # Change...

MINOR: Catch InvocationTargetException explicitly and propagate underlying cause

3

InvocationTargetException always wraps an underlying cause. It makes sense to catch it as soon as possible and only propagate the underlying cause. # Change 1. Replace "legacy" [1] with `getCause()`...

KAFKA-13036: Replace EasyMock and PowerMock with Mockito for RocksDBMetricsRecorderTest

6

## Changes 1. Migrate to Mockito 2. Add more assertive checks using `verify` 3. Minor indentation fixes ## Testing `./gradlew streams:unitTest --tests RocksDBMetricsRecorderTest` is successful ## Notes to help the...

KAFKA-12950: Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

3

This PR build on top of https://github.com/apache/kafka/pull/11017. I have added the previous author's comment in this PR for attribution. I have also addressed the pending comments from @chia7712 in this...

KAFKA-14132: Replace PowerMock/Easymock with Mockito for WorkerMetricsGroupTest

1

1. Note that `@RunWith(MockitoJUnitRunner.StrictStubs.class)` ensures that all declared stubs are called, otherwise it throws an exception, hence there is no requirement to `verify` stubbed methods. 2. Note that there is...

KAFKA-14248: Fix flaky test PlaintextAdminIntegrationTest.testCreateTopicsReturnsConfigs

2

Test is failing intermittently because we do not wait for propagation of the altered config (LogRetentionTimeMillisProp) across all brokers before proceeding ahead with the test. This PR makes the following...

KAFKA-7109: Close fetch sessions on close of consumer

7

## Problem When consumer is closed, fetch sessions associated with the consumer should notify the server about it's intention to close using a Fetch call with epoch = -1 (identified...