Disco

Thankyou so much for this issue - and solution. I too had built carton from source, and after getting it to build, I wasn't sure where to put the binaries,...

Whether position is a configuration setting or not is a debatable point, because it is a property that gets modified by the 'moveTo' method in the proxy. Configuration parameters should...

Thankyou for taking the time for such a comprehensive review! :D . I’ll reply to the other comments separately, but will follow your guidance here. The new approach to creating...

Agreed. I’ll do that. > On 7 Dec 2024, at 11:48, Paul Hudson ***@***.***> wrote: > > > @twostraws commented on this pull request. > > In Sources/Vortex/Settings/Settings.swift : >...

Ahhh. I see now what you meant about sharing prebuilt views - the symbol views. I’ll think about this some more. > On 7 Dec 2024, at 11:42, Paul Hudson...

Agreed. Will change to: _ settings = VortexSettings(), I’ll remove the old VortexSystem init . > On 7 Dec 2024, at 11:31, Paul Hudson ***@***.***> wrote: > > > @twostraws...

Agreed. > On 7 Dec 2024, at 11:29, Paul Hudson ***@***.***> wrote: > > > @twostraws commented on this pull request. > > In README.md : > > > ```swift...

Agreed > On 7 Dec 2024, at 11:27, Paul Hudson ***@***.***> wrote: > > > @twostraws commented on this pull request. > > In Sources/Vortex/System/VortexSystem.swift : > > > -...

It doesn’t offer much, that’s true. The only thing it does is allow the entire settings, including secondary settings, to be created within the closure. Like the example below. It’s...

Re. Odd shaped initialiser: The difference is highlighted more succinctly in use between these two Previews, which both do the same thing. A closure is required in both cases, but...