Brendan Jurd

Results 22 comments of Brendan Jurd

I agree with @xerc. It is a bit rough to expect the caller to go digging around in custom attributes of the exception object in order to extract the necessary...

My PR #150 was just merged, I think that this issue can now be closed.

> > it would be nice to have test/gie/builtins.gie extended to test the fixed cases > > this point remains to be done I have added some tests on my...

I'm speculating here, but the comments in the unreachable code talk about aperture 3 and 4: ```cpp /* Aperture 3 odd resolutions */ if (g->aperture == 3 && g->resolution %...

FWIW I ran the test in a venv on MacOS 11.5.2 / Python 3.9.7, and did not encounter the error.

I think the difference in behaviour with a newline at the start of the query has an easy solution. @lnicola is right that the leading newline breaks detection of 'SELECT'...

On a bit of a tangent, but the stated reason the PG driver has a different code path for SELECT is to avoid putting statements like CREATE DATABASE or VACUUM...

I did make clean between rebuilds, yes. I'll see about capturing the build log for gifdataset next time, thanks.

Hi @rouault I've got the line from the build log for you: ``` /Applications/Xcode.app/Contents/Developer/usr/bin/make -C gif install-obj /bin/sh /Users/brendanjurd/src/gdal/gdal/libtool --mode=compile --silent --tag=CXX g++ -std=c++11 -I/Users/brendanjurd/src/gdal/gdal/port -I/Users/brendanjurd/src/gdal/gdal/gcore -I/Users/brendanjurd/src/gdal/gdal/alg -I/Users/brendanjurd/src/gdal/gdal/ogr -I/Users/brendanjurd/src/gdal/gdal/ogr/ogrsf_frmts -I/Users/brendanjurd/src/gdal/gdal/gnm...

This remains broken for me as of MacOS 11.6 and master d77cda87ea. I did a little digging and read that the giflib API had changed between major versions 4 and...