yan

see https://github.com/brave/browser-laptop/pull/13236#issuecomment-367480676 for details

misses TLS1.1/1.0 vuln servers

1

Currently uses the heartbeat bytes `\x18\x03\x03\x00\x03\x01\x40\x00`. Should be `\x18\x03\x02` for TLS1.1 or `\x18\x03\x01` for TLS1.0. BTW, the `\x40\x00` bytes at the end specify the length of data that the server...

sync build is failing on master

1

staging is fine however: https://travis-ci.org/brave/sync/branches

same issue as https://github.com/diracdeltas/niceware/issues/17

clarify/document what mainDevice is

1

browser-laptop implements the concept of a main device for sync: https://github.com/brave/browser-laptop/pull/13197/files#diff-23ca389e2bcb77191b5a9c10900eb3a3R559 my understanding is that the main device is the device that, when deleted, sends `DELETE_SYNC_USER` to the sync server,...

[suggestion] provide a `Clear my data from the sync server` switch/button

1

Per discussion in Slack, there should already be a way for clients to implicitly delete all sync data from the server, either when the last device is removed from the...

requested by serg and joel

Some URL schemes do not work cross-platform. Ex: browser-laptop: chrome:, chrome-extension:, about: (?) android: chrome-native: (?) ios: ? When these URLs are synced as a bookmark or history record, a...

ipc.send from browser-laptop doesn't work with Uint8Arrays

4

if the message contains a Uint8Array, it never gets sent for some reason. sending Uint8Arrays from webview to browser-laptop works fine though.

[Bug] spleeter::Initialize crashes if the registered session is being used

4

also found this crash report while using vstSpleeter (my fork) in ableton. seems related to spleeterpp/tensorflow? ``` Process: Live [60271] Path: /Applications/Ableton Live 10 Suite.app/Contents/MacOS/Live Identifier: com.ableton.live Version: 10.1.14 [2020-05-12_b749619222]...