Dino Radaković comments

Results 35 comments of


                                            Dino Radaković

Consider changing the name of the default branch from 'master' -> 'default'

As far as I can tell, renaming the default branch would only trivially break our internal import workflow. And the fix is a one liner. Feel free to proceed with...

Mock object leaks after EXPECT_CALL and EXPECT_EXIT with -1

Thanks for the detailed bug report. This is most likely caused by the interaction of things: 1. When defining the EXPECT_CALL on a mock object, GoogleTest adds it to an...

`MakeFileName()` creates hidden file in case `base_name` is empty.

This seems WAI to us, but we might consider having a patch that special cases empty filenames. Could you please explain how you encountered this issue?

Allow building googletest against absl using cmake

Would you mind rebasing?

Allow building googletest against absl using cmake

We'll take a stab at pulling this through our internal workflow next week.

Allow building googletest against absl using cmake

Would you mind rebasing once more? The change looks good, but our workflows are complaining about merge conflicts with head.

Allow building googletest against absl using cmake

We dropped the ball on this one because we didn't really care about CMake internally and didn't have much experience in using it. There was also a debate of whether...

Fix missing `json` extension in `kColorEncodedHelpMessage` in the description of `--gtest_output`

@bbarenblat: Please take a look.

"Rotten Green Test" detection

This sounds useful. We would consider accepting this change. However, before we start reviewing any pull requests, we would like to take a look at a comprehensive design proposal.

gmock-actions: suppress warning about unreachable code

Could you please identify the specific codepaths that trigger this warning? We would prefer to fix those instead of disabling it. The warning is disabled now, but we would prefer...