Tung Du
Tung Du
@browner12 You can import it, like this: ``` import Mousetrap from 'mousetrap'; import 'mousetrap/plugins/global-bind/mousetrap-global-bind'; ```
In [98f08ef](https://github.com/woocommerce/woocommerce-blocks/pull/6877/commits/98f08efdb8048b8f78c7476b774d1128c1d31295), I try to render the placeholder on the server side to prevent content flashing and layout shifting issues. The placeholder `is now displayed right after the page load...
Thank you so much for the reviews! > I changed the slider inputs to be inline by default @vivialice So for the Editable option, do we still allow the input...
@albarin Except for what I mentioned in the P2 comment, this is ready for another review 🙌🏽
> * "Price range selector" is all uppercase in the design. @vivialice can you confirm the "Price range selector" styled all uppercase is intentional? > * On the design, there's...
> The `Reset` button should appear regardless if the `Filter button` is turned on or not. It should also appear only if a selection has been made. @vivialice I'm a...
@vivialice @Aljullu I updated the Warning component copy and spacing in [c672048](https://github.com/woocommerce/woocommerce-blocks/pull/6191/commits/c672048a46d4b85c38e11ddc3c70e34c069b855b). Here is how it looks now:
> To confirm: the product search block will _not work_ if the user doesn't upgrade? Or will it still appear on the front end? @vivialice The legacy block will continue...
@Aljullu I would like to pause merging this PR to think about the post-deprecation process. Eventually, we want to remove the `DeprecatedBlockEdit` and the legacy Edit/Block component. So how will...
> I'm not sure if I agree to consider this a blocker, though. That component is only loaded in the editor, and its performance impact should be negligible, right? Yes,...