Diego Ortin comments

Results 19 comments of


                                            Diego Ortin

Support baseline coverage

Any updates?

proposal: add a `set` data type

@suganoi that's nice! I have also just seen https://github.com/bazelbuild/starlark/issues/20, but it doesn't seem to include the existence of `set`. IMO the `set` API selected for the Go version makes sense...

pkg_files remove the executable permission to generated executable

When adding files to a `PackageFilesInfo` from `DefaultInfo`, the executable is detected and its permissions are changed to `0755` https://github.com/bazelbuild/rules_pkg/blob/c53ff51070c96b368188f057a6683d97c31b77f7/pkg/private/pkg_files.bzl#L411 I'm not sure why that wouldn't be happening here

No perf benefit with Bazel

@pdeva did you ever find out what the issue was?

No perf benefit with Bazel

@rdeushane unless you have a custom rule, tests are linked dynamically in Bazel AFAIK

Test indexing in Clion takes a very long time

I’m also affected by this on CLion 2023.2

`copy_to_directory` includes all files as runfiles

That’s a good idea. Our current workaround is to have a custom rule that removes all runfiles from a target (we’re copying only C++ source files in our case)

`copy_to_directory` includes all files as runfiles

What about adding an attribute that does not add to runfiles? That would make the change non-breaking, although I’m not sure about naming

add magic_enum

Why is patching the `.bazelrc` needed? I thought only the one in the project root would apply, and not the ones in modules you depend on

pkg_tar rule break the symlink and cause link error at runtime on MacOS

Are those shared libraries prebuilt? Or are you building them with Bazel? In my case, I’m packaging binaries with lots of shared libraries and haven’t encountered this problem. But I...