YONGJAE LEE(이용재)
YONGJAE LEE(이용재)
안녕하세요! Referencing Values with Refs, Manipulating the DOM with Refs 작업해보겠습니다~
좋은 서비스였는데 아쉽습니다..
I really appreciate about your review. 👍 👍 As you mentioned, the issue was caused by EDITOR_SETTING being triggered before PARAGRAPH, which led to short-circuit processing. However, modifying the condition...
> Nice fix! Since the `setTimeout(..., 200)` is a heuristic to dodge a race, could we add a short comment explaining (1) why it's needed and (2) a TODO o...
c90cd09 - Made `notebookParagraphCodeEditorComponent` optional. 5e35dbf - Added a comment for `editorSettingTriggerAllowed`. 6c993a0 - There are two related actions: `CLONE_PARAGRAPH` and `INSERT_PARAGRAPH`. Each needs to be handled slightly differently. ####...
I rebased due to conflicts caused by merged PRs.
@seung-00 I found your merge commit(daa45c1) is empty. Could you rebase again? Because CI Failure caused by zeppelin-zengine issue. It was solved(#5081) and merged to master branch. https://github.com/apache/zeppelin/actions/runs/18057550292/job/51390882307?pr=5085#step:10:16071
I didn’t carefully review the PR description, so I didn’t realize it also included changes related to zeppelin-zengine. It seems that some of the current test failures(NullPointer) are likely due...
You can see that request item 1 has been addressed in e92d5ae and item 2 in eea335a. Thank you for the thorough review.
It took some time to incorporate the review feedback, do incremental refactoring, and clean up the tests that were failing in CI. I’ve opened #5128 with the common environment and...