Diana Popa

Results 42 comments of Diana Popa

> @sandreim Thanks for the comments. Sorry I had to copy the conversation over as I fumbled the previous PR. > > > I would suggest to deprecate the current...

> > > I would suggest to deprecate the current API > > > > > > I think for now, I will leave it as-is. I wouldn't want to...

Did you remove the binding manually or re-run rust bindgen?

Do we maybe want to combine this rust update with ubuntu update? I am thinking about saving some devctr entries?

Hi @austinvazquez Very happy you want to help with this issue. The steps you propose sound good to me. I will help you with pushing the docker image once the...

@CompuIves you need to rebase your PR so that we can go ahead with the merge

Hi @Pennyzct , it is really nice to see this! We were looking forward to this kind of functionality, see #1339 which was being tracked as part of our efforts...

> Change looks good to me. Interesting that we have performance targets configured but not run for (automatically) up until now. Indeed it is a little confusing. I did a...

Thanks @mattschlebusch and @bchalios for the review! As you can see in the failing test the AMD deserialize baseline needs some adjustments. I did some digging to see why this...

@bchalios @mattschlebusch I regathered the baselines and tested them against multiple runs. All seems good now, can you please review again? Thanks