liuzhenwei

icon indicating an email [email protected]

icon location Shaanxi Xi'an icon location Cloud Native

Results 9 comments of liuzhenwei

Refactor the code to improve code quality and More concise code logic

Thanks for your comments. Yes, it is a retry-able mechanism, but there are some logical errors in switch statement. The condition in the if statement is always false at the...

[feature request] add inPlaceUpdate restart count to annotation

I implemented this in my own environment and the result is shown below： Annotations: ``` apps.kruise.io/inplace-update-containers-restart-count: '{"nginx":{"revision":"sample-d97f89dcf","restartCount":1,"timestamp":"2022-03-24T08:03:23Z"},"sidecar":{"revision":"sample-d97f89dcf","restartCount":1,"timestamp":"2022-03-24T08:03:23Z"}}' apps.kruise.io/inplace-update-pod-restart-count: "2" ``` `apps.kruise.io/inplace-update-pod-restart-count`: The Pod restart count. `apps.kruise.io/inplace-update-containers-restart-count`: Every container restart count...

Inplace update restart count

/assign @fei-guo

Why do we always need to judge the log level before printing the log in business logic?

Thanks for your reply. @jizhuozhi I agree with you, just like the code below, we need to make a judgment before printing the log: ``` if log.DefaultLogger.GetLogLevel() >= log.DEBUG {...

[BUG] ImageID unchanged, in-place upgrade block

Is kruise-daemon running successfully on all nodes?

Sidecar terminator ignore the exit code of the sidecar container

will do

[feature request] Sidecar terminator ignore the exit code of the sidecar container

This is my workaround: #1303 @zmberg PTAL

pod.status.containerStatuses displayed image name incorrectly when image has multiple tags on the node

Thank you for your prompt reply。@afbjorklund In kubelet, It starts the container through the following steps: // * pull the image // * create the container // * start the...

Provide way to remove metric that are not published anymore

+1