Danek Duvall
Danek Duvall
IMHO, the `--tabs` option is still useful, since it's how you get raw tabs in the output (if you want that), and with tab alignment (#729, #751), people using tabs...
Great code review, thanks! A couple of questions, though: - Why is `.graphemes()` needed at all? The codeābefore or after my changeādoesn't do anything with them, and just looks for...
Why do we need to iterate over the graphemes? If a tab is guaranteed to be the one character in a grapheme, then we don't need to process the graphemes...
Sorry; my life has been upside-down the past few weeks. I'll see if I can give it some attention this long weekend.
Right; there's no way to guarantee that it'll do the right thing. But it can do better than it does currently, if we make this assumption about terminal tab width....
This also means that when I'm mocking `Obtain()`, I don't have any way of making my mock return one of the actual errors it'll get, so my testing won't be...
It's not clear to me if I run into the 5-`badNonce` limit, if that really means something's wrong, and there's no point in trying again, or whether the error is...
What context are you looking for? I can give you the logs from that run. Is there anything else?
This happened with two concurrent calls to `Obtain()`, each for an order containing two domains, one of which is a wildcard. That is, order 1 is for `a.domain.com` and `*.a.domain.com`,...
Leaving a comment so this doesn't get too stale.