Derek Guenther

Results 10 comments of Derek Guenther

This is probably it -- Node.js docs indicate [`filehandle.createWriteStream`](https://nodejs.org/api/fs.html#filehandlecreatewritestreamoptions) was added in v16.11.0. This has been fixed in the latest release

I made a quick spreadsheet to demonstrate the issue + this fix. In the current code, we: * Initialize step_size to the number of threads * Initialize batch_size to some...

I'll follow up with @adi7dev on this.

I've been running [node-datachannel](https://github.com/murat-dogan/node-datachannel) successfully for a time, but I've only tested the data channels, not the media support. Another option I've seen is [werift-webrtc](https://github.com/shinyoshiaki/werift-webrtc). When I tested it a...

Is there an issue for it? Offhand I wouldn't expect that, since as far as I know werift doesn't use any native modules.

Thanks for the detailed problem report! We shouldn't crash the node process in this case for sure. It looks like the error was actually getting thrown from `createDataChannel` -- it...

I came across a similar crash when working on #21882 with this test: https://github.com/servo/servo/blob/76ddbe4d7afd48b83b23f3fd0cff47b214a0a290/tests/wpt/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/quirks.window.js#L41-L47 a minimal repro: ```html const frame = document.getElementById('test'); frame.contentDocument.open(); frame.contentDocument.appendChild(frame.contentDocument.createElement('div')); frame.contentDocument.close(); ``` A few lines from...

Correct, the error message isn't very clear, but the start of it describes it. You'll need to use Node.js v16 instead of v18. ``` npm WARN EBADENGINE Unsupported engine {...

For us, this was happening because our app explicitly calls `destroy` on a BrowserWindow. ## Reproduction You can reproduce it by calling `win.destroy()` in the `ready` event handler in the...

This makes sense to me. I'm not sure where the "discovers a new block" log would be best placed, but I'd expect most of the time to be consumed starting...