Demetrio Girardi

Results 275 comments of Demetrio Girardi

Technically reverting this behavior is also a breaking change (sending aliases server side if no client side adapter exists): because if people are currently setting up aliases for other purposes,...

I also think that should probably include `2`. There was some discussion in https://github.com/prebid/Prebid.js/pull/8086#discussion_r863957819 but I'm afraid I don't recall the full context. @musikele do you remember why we agreed...

I would be careful about labeling this a security parameter; Prebid does not attempt to enforce it, and I bet neither does PBS. If any downstream DSP puts a JS...

I am tackling this as part of https://github.com/prebid/Prebid.js/pull/8738, with this logic: - use what's currently hardcoded as the default request, ``` const defaultRequest = { context: 1, plcmttype: 1, eventtrackers:...

Actually - reading the [native spec](https://www.iab.com/wp-content/uploads/2018/03/OpenRTB-Native-Ads-Specification-Final-1.2.pdf) - I am not sure that the default we now set for `context` and `plcmttype` make sense, so maybe it's better to discard them...

The issues I see with a top-level config like `ortbNative` are: - most properties do not make sense as global config. looking at [the spec](https://www.iab.com/wp-content/uploads/2018/03/OpenRTB-Native-Ads-Specification-Final-1.2.pdf), the only ones I see...

core's `adapterManager` exposes UPS and GDPR consent data, this is an example of a module using them: https://github.com/prebid/Prebid.js/blob/5abf5c3af94eba9736ccf6cdc623adb0f98ed767/modules/liveIntentIdSystem.js#L85-L89 Would that work instead of the duplication? An issue I see is...

@ym-abaranov the handler interface, and its interaction with the consent management modules, could be modified to address those points with a much smaller footprint compared the replication of the consent...

@ym-abaranov I'll post a PR with the handler changes. exporting/importing across modules does not work well because the webpack compilation would repeat the code on both ends (since all modules...

https://github.com/prebid/Prebid.js/pull/8071 should allow you to call `gpdrDataHandler.promise.then(...)` and `uspDataHandler.promise.then(...)` instead of the lookup functions.