Devin Howard
Devin Howard
I'd love to see this happen @bdauvergne, but I don't have time to really dig in to it. I experimented today and came up with this, which hopefully is the...
Hi You're correct I'm not actively working on this project at the moment, since I'm not working on any React/Redux projects. I'm happy to support pull requests as needed though!...
Hey sounds like a plan! Would you be willing to test this locally and submit a pull request?
Can you publish a sample response so I understand your use case? It sounds like this is just a conflict between users of the data-envelope approach and the non-data-envelope approach....
That's a good question. I think what you're describing is the headers of the error The default ApiClient (https://github.com/devvmh/redux-crud-store/blob/master/src/ApiClient.js) doesn't pass along the headers of the error. I have some...
for example, someone might be manually checking the text() value of the response if the status is 204 (this is something I've done before). That would then fail if we...
@dzwiedziu-nkg have you gotten a chance to look at this PR again?
Thanks for this issue! The updates to the Flow spec of the return type sounds like a positive change. I'm more hesitant about removing data envelopes from the lib. In...
I agree it's a major simplification to the logic of the lib. But for users, it pushes just a little bit more work onto them. I'd rather see a PR...
I think this is supposed to work for the multiple resources case but not for the single resource case The default ApiClient.js, assuming no errors, returns fetch api's `response.json()`, which...