Samuel Kohonen

Results 14 comments of Samuel Kohonen

Hey! I assume you have tested this in production so the change is good for Azure and works in production? Really like how the never libraries allows for some code...

Verified that integration tests for GCS work even after the threads are patched.

@fdr Merging this probably means we need a version bump. Any thoughts on this? We should probably release a new version anyway now that the python 3.6 errors are fixed.

Instead of using TemporaryFile we could also refactor the downloading part to an iterator that yields for each chunk? So in `write_and_return_error` we can just write those chunks one after...

I've seen this error a few times but too sporadically to really look into it more. Since exception raises all the way from the python http client I guess we...

It seems that switching to the newer client isn't that straightforward. I got most of the glitches fixed but I think I've stumbled upon a bug in the actual google...

How did you setup the retries? I'm a bit sad if we need to add another level of retries since the google client already does retries. See the lines you...

I was afraid you would say that. :) From the stacktrace it looks like `upload_from_file` uses `upload.stream_file` which never actually receives the num_retries given. Instead (as far as I can...

You are correct that BadStatusLine is a retryable exception and looking at the log it has retried that 5 times. I am testing a version of wal-e now that uses...

As far as I've seen we do fail properly so no backup_sentinel.json file gets uploaded. I've now tested the updated library enough to feel comfortable upgrading it. @fdr, do you...