Jason Miller

Results 1202 comments of Jason Miller

Just a thought - any chance you noticed this audit failing during development mode? (`npm start` / `preact watch`) During development mode prerendering is disabled, since it breaks caching.

@MarkGeeRomano Automatic polyfill injection would be a nice feature, but there are no current solutions for doing this that work well. Preact doesn't polyfill runtime APIs because doing so universally...

@marlonmarcello FWIW the solution from #457 can be tweaked to support prerendering: ```js import App from './components/app'; import { render } from 'preact'; let app; if (typeof document === 'undefined')...

heh - yeah that was vague haha. When Preact CLI loads your app in the browser, it has to choose a DOM element as the root in order to hydrate...

Hmm - so your first example seems the most correct, but I had forgotten that in dev mode we don't do prerendering. Because of that, the CLI will always render...

Changed the label to has-workaround since we have at least narrowed it down to a dev vs prod thing (there's no solution that works the same in both).

Hi @JCofman - Preact CLI doesn't actually compile SW during development (preact watch). It serves a [debug sw.js](https://github.com/preactjs/preact-cli/blob/master/packages/cli/lib/resources/sw-debug.js) that is mainly there to replace any stuck production Service Worker, but...

The 5 character hashes are 20 character hashes that have been truncated, similar to a "short hash" often used in Git. This is sufficient because hashes are designed to vary...

~oooh that's a strange one. I'm not actually sure where we're creating a temp directory.~ found it!

This is a problem caching should be used to solve. Since there are over 1000 npm modules at play here, caching is sortof an upstream issue. There's a lot of...