Jason Miller

Results 1202 comments of Jason Miller

@rschristian I was thinking that was the case, yeah. Neither should have it, or at least the modern one shouldn't have it (the legacy sw file never gets used, no...

Darn, function `Use` entries are only supported as of Webpack 4

This is happening because you have 2 elements with the ID preact_root. When Preact boots up, it gets a reference to the first one, which is the empty duplicate you...

Hmm - this is an odd one. It might be worth us adding an option to define `SW_PATH`? ```js navigator.serviceWorker.register((SW_PATH || __webpack_public_path__) + 'sw.js'); ```

This is likely due to Critters. Can you try with the most recent preact-cli version? It has been updated to Critters V2.

Ah yes, apologies. I also missed that you provided a reproduction.

Can you paste the output of `npm ls --depth 0 | grep preact`? Getting `` in your HTML means you're either ending up with a copy of Preact 8 somewhere,...

Hiya - this is almost certainly caused by the `react-html-parser` library you're using here: https://github.com/RomanistHere/RomanistHere.github.io/blob/3a08995fdf2fce84c8077ad713dcf1cdae1e4aae/src/pages/Post/Post.js#L45 There's not much benefit in that library given that it doesn't sanitize HTML. You could...

@Chalapathi01 hmm - are you sure it's not caused by the `@-webkit-keyframes` section? In general, `-webkit-` prefixes should not be necessary in preact-cli, it will generate browser-compatible CSS for you.

Body content from the template is preserved during prerendering. I'm on the fence about this one. It seems like lighthouse is recommending an actively harmful technique here, though checking the...