0xDEVARSH

Results 18 comments of 0xDEVARSH

@Ainali isn't this the expected behaviour? Because, Amavenita (ship, 2014) is a non-hidden category and I think we are only supposed to show the hidden category in search bar. But...

> By the way, when I search for "rabbits", the first result is https://commons.wikimedia.org/wiki/Category:Rabbits which is not a hidden category: > > ![adb](https://user-images.githubusercontent.com/99590/159115296-dff3836c-346d-4088-b66f-00e2c4f8d59e.png) Yes that is how it should work...

> Do we all agree on this? agree

@nicolas-raoul do u recommend providing this option in settings or on the category selection screen or both?

> Thanks @sivaraam that's indeed much better! > > 2. Perform a second API call to check whether the typed string is the exact name of an already existing category....

> After performing API calls 1 and 2, you would concatenate the results: > > * Result of API call 2 (if not an error) as the first suggestion. >...

Should I do it in my existing PR itself? It is part of it. Thanks : )

> Thanks for showing interest @devarsh-mavani-19, we recommend solving each issue in a different PR. @4D17Y4 sorry for delay in responding. Actually adding this feature https://github.com/commons-app/apps-android-commons/pull/4874 Will automatically solve this...

@nicolas-raoul can you please review this? thanks

> The problem seems to not exist on master. means is it caused by this PR?