Denis Bilenko

Results 28 comments of Denis Bilenko

> > Should gevent also patch signal.signal and friends to further protect itself from the user? I don't think so. There is a use case to use signal.signal rather than...

Right, patch_all() already patches subprocess by default, so any kind of explicit opt-in would not fit there. Nevermind.

@andrewnester @pietern should we revive this at least for PRs? We have 40 open PRs now https://github.com/databricks/cli/pulls it seems some old ones should be closed.

Reopening - we should fix the crash or verify that it does not happe.

I checked this config, there is no crash anymore. ``` ~/work/cli/acceptance/bundle/issue1491 % cat databricks.yml bundle: name: my_project targets: dev: mode: development default: true resources: model_serving_endpoints: name: pd-model config: auto_capture_config: enabled:...

This patch seems to fix this test: ``` diff --git a/src/python/grpcio/grpc/_cython/_cygrpc/aio/server.pyx.pxi b/src/python/grpcio/grpc/_cython/_cygrpc/aio/server.pyx.pxi index 8332c5a0d5..2df89c86a4 100644 --- a/src/python/grpcio/grpc/_cython/_cygrpc/aio/server.pyx.pxi +++ b/src/python/grpcio/grpc/_cython/_cygrpc/aio/server.pyx.pxi @@ -414,7 +414,7 @@ async def _finish_handler_with_unary_response(RPCState rpc_state, sync_servicer_context = _SyncServicerContext(servicer_context)...

@sourabhsinghs @sreenithi I've added a couple of tests, please take a look. A few more can be added in this manner.

Long term we're planning to stop depending on downloaded terraform binary. Short term, you can set up docker image by pre-downloading the needed binaries and setting up some environment variables....

> Is there any update on plans to stop depending on the downloaded binary? Yes, we're working on new deployment method that does not use terraform and that would make...

We do want to revamp the output/logging system and make logs and output work well together.