Marnix

Results 43 comments of Marnix

@hboisgon and @savente93 Here is my draft PR. The following things are not yet in: - [x] Assigning another region to reference to via the constructor of a component. This...

I have done another overhaul and came to a better design with @hboisgon . We went for a leaner SpatialModelComponent that only does the check for a reference component, and...

After more discussion with @hboisgon and @savente93 , we have come to a bit different conclusion. Every GridComponent will need its own region. Therefore, we will rename `ModelRegionComponent` to `SpatialModelComponent`....

After more discussion with @DirkEilander again, we have come to the conclusion that it's better to keep the ModelRegionComponent as it is and not let GridComponent subclass from it. We...

It sounds like we are looking for new types of components that the `ModelRegionComponent` cannot cater at the moment. I would say that we create some other classes that could...

sub regions are currently not part of the simple `ModelRegionComponent`. If we want to expand on different types of region definitions I would go for something like a `CompoundRegionComponent`, and...

I don't have a PR yet, but this is what it would look like https://github.com/Deltares/hydromt/compare/refactor-model...region-component-2 So far I have: * Removed `region` as a command line argument * Given `GridComponent`...

We've been playing around, also with the `write` step and found that it would probably be easier to stick closer to the Github actions syntax. Where `with` will be the...

Is my PR #888 ticking all the boxes for this feature?