David DE CARVALHO

Results 94 comments of David DE CARVALHO

sorry @zippy1978 ... but new conflicts to resolve, please :p

Hi @MaximeStM, please resolve conflict, then check DoD list here https://github.com/green-code-initiative/ecoCode-common/blob/main/doc/starter-pack.md#definition-of-done-of-a-pr

Hi @tazemar, thank you for issue. It's a good idea. Please take into account my review feedback on your PR.

Hi @dirdr, please take into account remaining review notes and correct the code small raised by sonarcloud.io thank you.

Hi @dirdr, no, I didn't work on this PR, sorry. Once current task is over, this is my next priority ... with two others CRJVM205 JIRAs :p

Hi @dirdr, sorry there is another conflict to resolve, please. and then, check DoD list here : https://github.com/green-code-initiative/ecoCode-common/blob/main/doc/starter-pack.md#definition-of-done-of-a-pr

PR on java-test-project : https://github.com/green-code-initiative/ecoCode-java-test-project/pull/5

to discuss in core-team : - good argument to prove it's a "green" rule - no native Sonarqube rule found but I think we can't force developers not to use...

Hi @saidmohamedali, thank you for this PR ... but I saw that you created and closed some 3 old PRs with same modifications (#150 / #168 / #169) related to...

Hi @saidmohamedali, do you check DoD list ? please check here https://github.com/green-code-initiative/ecoCode-common/blob/main/doc/starter-pack.md#definition-of-done-of-a-pr