Alessandro De Blasis
Alessandro De Blasis
> Hey @deblasis > > Super excited to see this PR come through, thank you! After looking ( and asking ) around it doesn't look like we have any established...
Hi guys, sorry for the delay. I have updated the PR taking into account your feedback and I made a small improvement in the reported service state that's now in...
Hi @kisunji! Sorry about that. But I have good news 👇 > * We need to initialize `checkOSServices` otherwise there is a panic due to assigning to a nil map...
Hi @johncowen ! Nice seeing you again around here (you reviewed a PR of mine back in the day) :) > If the `Type` field in the HTTP response that...
@trujillo-adam: > Had a few suggestions and questions w/r/t the docs. You did a really good job on the main description of the OS service check, BTW. Suggestions accepted! Thanks...
👍 On Mon, 29 Aug 2022 at 18:05, Chris S. Kim ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In agent/agent.go > : > >...
I think it should be OK now. Shall we🚢 it ? 😄
Hi there, I bumped into this issue and I would like to contribute. I am a huge Hashicorp fan and shamelessly wannabe Hashicorpian too 😄 That said, I wanted to...
Hi @jkirschner-hashicorp, you are welcome! I tried, hopefully, it's easier this way. Thank you for the update. It sounds fantastic! Take your time. Best
Hi @rismoney, it is completely my fault I guess. The team provided feedback, we are aligned with the design and there are no blockers. I just had to write the...