Deane Barker

Results 17 comments of Deane Barker

Could you change the code to: ``` if(!fileInfo.Exists) { return new FluidTemplate(new TextSpanStatement($"MISSING TEMPLATE: {path}")); } ```

I think we're going to file a pull request to allow the setting of whatever template you want in a "not found" situation. The default would be an empty template,...

That method needs a return value. Is your idea that the delegate could return a template in addition to doing something else? So... ``` TemplateOptions.Default.NotFound = NotFoundHandler; private IFluidTemplate NotFoundHandler(string...

I wrote this extension method that uses the same `IFileProvider` as `include`: https://gist.github.com/deanebarker/174bf177a7c393fdbaadfb44acf16273 ``` parser.ParseFromFile("/path/to/file"); ```

If `ArrayValue` can convert to a number, why shouldn't `DictionaryValue`? They are both collections of items, one just happens to have keys.

I guess was just confused by the discrepancy. Why does `ArrayValue` return a number and `DictionaryValue` does not? Did we just reproduce some Shopify weirdness?

Explain how you think these should work. I looked through the Liquid doc and didn't see them there. What type of value would these operate on? What would these output?

The filters on that page are Shopify-specific. Do you want these for raw Fluid, Fluid used as a ViewEngine, or Fluid used in some application?

But, again, those filters aren't technically on _Liquid_. They're part of _Shopify_. Yes, but the problem is that forming a path to anything requires knowledge of where that thing is....

I would probably do this as an identifier on a new value class? If you do it as a filter, then it could be used on something which doesn't have...