Dominic Scharfe comments

Results 6 comments of


                                            Dominic Scharfe

EngineDiscoveryOrchestrator does not exclude filtered TestDescriptors if they contain children

I am using a `PostDiscoveryFilter` and it returns `FilterResult.excluded("REASON")`, but the descriptor has children and is therefore not excluded due to the implementation of `EngineDiscoveryOrchestrator::isExcluded`.

EngineDiscoveryOrchestrator does not exclude filtered TestDescriptors if they contain children

It does, but `EngineDiscoveryOrchestrator::isExcluded` ignores the filter result because the descriptor has children (see my first comment).

EngineDiscoveryOrchestrator does not exclude filtered TestDescriptors if they contain children

Thanks for your suggestion @marcphilipp. I thought about that too, however this violates the "contract" (aka JavaDoc) of `PostDiscoveryFilter`, because I would have to set some kind of state on...

EngineDiscoveryOrchestrator does not exclude filtered TestDescriptors if they contain children

I worked around this issue by not using a `PostDiscoveryFilter`. Instead I do the filtering in my `SelectorResolver::resolve` implementation and don't add the respective `TestDescriptor`s in the first place. Unless...

Context Buttons for Selection and Hover of EditParts

:+1: It would be really nice to have this feature in gef.

Draw2d generating lots of garbage during repaint

HI @azoitl. Removing the clipping would definitely break our code. I think for many use cases the overhead of clipping is no problem, so perhaps the best approach would be...