ddl-rliu

Results 12 comments of ddl-rliu

See https://github.com/flyteorg/stow/pull/11#issuecomment-1979815168

Right, that makes sense. Since values like mem/cpu are variable inputs, it's actually desirable for them to not cause changes to the version string. What might be better is, for...

> Maybe we need to add that as a config? Another idea that I thought of is to extend [Enable flytekit to be pluggable](https://github.com/flyteorg/flytekit/pull/2039) – and extend the version hash...

Some extra context: ## Intentional behavior I am not sure, if this bug could actually be intentional behavior. The execution spec contains, in addition to the `spec.security_context.run_as.execution_identity` field, a `spec.metadata.principal`...

I've updated the issue with a focus on the 'Recover' operation (which is possible via UI). In addition to "Recover", there a similar bug with the Relaunch grpc endpoint. When...

FYI some PRs which implement a fix to this issue. https://github.com/flyteorg/flyte/pull/5604 (this should land first) https://github.com/flyteorg/flytekit/pull/2426 (this should land last)

Closing since both PRs have been merged. Thanks! 🎉

@thomasjpfan Thanks, it's an interesting idea, and I never thought about that possibility! With a modest refactor of `_version_from_hash`, particularly to accept `entity` as a parameter, I think it will...

Tracking issue: https://github.com/flyteorg/flyte/issues/5603