Daniele Di Proietto

Why can't we use pthread_mutex with PTHREAD_PRIO_INHERIT? We can set PTHREAD_PRIO_INHERIT only if the flag is enabled. On non-linux, sure, let's keep using std::mutex. Benefits of using pthread_mutex: * We...

Thanks for doing this! Useless complaint: this still doesn't give us perfect control over tracing categories. An explicit priority based approach (iptables style) woud be more powerful, but perhaps not...

If you want to pile up another breaking change, I was thinking we could disable all categories that don't match anything by default. We had some discussions a year ago...

Also, can I ask you to check in a test like: ``` auto* tracing_session = NewTraceWithCategories({"foo"}); EXPECT_TRUE(TRACE_EVENT_CATEGORY_ENABLED("foo")); ``` that covers most of the scenarios in the bug, BEFORE submitting this...

Discussed offline: the ideal solution would be to use something like `fts_read`, at least on linux, so that: * We also handle symlinks in directories * We're protected against symlinks...