Dan Bungert

Results 39 comments of Dan Bungert

Something very strange is happening when I VM test this branch with autoinstall. Using a fairly boring autoinstall set https://gist.github.com/dbungert/a48ea4d6291daa2e2bc53fbd2056a33b, one that works fine with main branch, on this branch...

> Right, but - does it break translations when we use `_` for other purposes ? In this case, no. I realized yesterday that I have been just assigning to...

> I recommend replacing _ by __ for throwaway variables. I think I'm going to ask that we not do that, that's probably OKish in the terminal font but I...

@jpnurmi - meant to address LP: #1983036, as observed with ubuntu-desktop-installer

> > Installing with the old installer (ubiquity) the screen 'Edit partition' allows formatting the partition but with subiquity the checkbox 'format' is grayed. > > After these fixes have...

> Oh one more comment, if the client sets wipe to false but sets a fstype that does not match the original fstype, that's an error right? Should we try...

Hit the re-review button since there is a logic change on the last bit.

@slyon thoughts? @maristeslk - Thanks for your contribution. Getting a better default set sounds like a nice fix. Before I can merge this I will need to ask that you...

I think the curtin conversation has settled, shall we wake these two MPs up?

Thank you all for the feedback. I see now that I can't assume that networkctl has all the capability I require. I lean toward the 'vendored' solution - that should...