David Borman

There was one more place where it was only looking for `nvme`, in `pkg/sysfs/syspath.go`, hence the force-push to fix that other location. With that additional change I am no longer...

Thanks for the review @akhilerm. I think I have addressed all your comments. In addition, I made a fix for `make test` so that it will run all the go...

> LGTM > > On another note: which are the tests that fail if you have only NVMe disks on your machine? My assumption was that we were not directly...

So, https://github.com/openebs/node-disk-manager/blob/develop/api-service/node/services/listBlockDeviceDetails_test.go#L30-L33 is hardcoded to `/dev/sda` Second, https://github.com/openebs/node-disk-manager/blob/683879d938b72464361e595171a9287d0f93fe4d/pkg/udev/mockdata.go#L117 is going to find the root disk, which in my case is an NVMe disk, and that leads to assumptions failing, like...

- @Pankhuri-Rajesh please go through and mark as `Resolved` all the comments that you have addressed - Are you anticipating making more changes? If not, change it from `Draft` to...

- There continue to be multiple lines with trailing whitespace, here's a search from within `vi`: ``` :g/ $/l 12.^IEasy to deploy and manage. $ LIO (Linux IO) - an...

Please make this change to get rid of multi-byte characters: ``` diff --git a/operations/iscsi_sbps/iscsi_sbps.md b/operations/iscsi_sbps/iscsi_sbps.md index 4f2be37931f..75027dc8897 100644 --- a/operations/iscsi_sbps/iscsi_sbps.md +++ b/operations/iscsi_sbps/iscsi_sbps.md @@ -38,11 +38,11 @@ In CSM 1.6, both...

I've marked as `Resolved` all the comments that I've verified have been addressed in the document, leaving just a few outstanding items.

> > Please make this change to get rid of multi-byte characters: > > ``` > > diff --git a/operations/iscsi_sbps/iscsi_sbps.md b/operations/iscsi_sbps/iscsi_sbps.md > > index 4f2be37931f..75027dc8897 100644 > > --- a/operations/iscsi_sbps/iscsi_sbps.md...