Daniel (dB.) Doubrovkine comments

Results 3350 comments of


                                            Daniel (dB.) Doubrovkine

adds ratelimit as a property of model(s)

@adamwolf please open a PR!

athlete_activities should return [Strava::Models::SummaryActivity] and not [Strava::Models::Activity]

There's a lot of summary/detail situations in Strava API and for whatever reason I had chosen not to rebuild that hierarchy in this client. I would be open to refactoring...

Strava V3 deprecates attribute `type` for Activities

Thanks, care to PR an update?

Strava V3 deprecates attribute `type` for Activities

I think we definitely need at least _some_ new K7s that show a complete new response, but I don't think you need to try and update all of them from...

Error and status not reported into Strava::Errors::Fault

We probably need to specialize the error in all the right cases to expose these fields. PR welcome.

Rate limiting

@adamwolf Rebase this change so that it doesn't have any conflicts and get it to green, I'll take a look at the PR once it's there! Feel free to squash...

Minor: Handle special error format for create_upload endpoint. #22

This feels incorrect. The API has predictable response and we're trying to be too smart about handling it. According to Strava documentation this endpoint returns a [Fault](https://developers.strava.com/docs/reference/#api-models-Fault) which returns only...

Minor: Handle special error format for create_upload endpoint. #22

I've opened [a ticket](https://support.strava.com/hc/en-us/requests/1471180) with Strava, which told me to email [email protected], which opened a ticket #2799.

Minor: Handle special error format for create_upload endpoint. #22

Given what Strava said we should fix this here, but not by modifying the base class. It's a special case for `upload`, so we can handle it there. I tried...