Daniel (dB.) Doubrovkine

Results 3350 comments of Daniel (dB.) Doubrovkine

I like this OK, so would merge something like this. The URL being a structure, I'd want to make sure the API verb is POST and the path is `/uploads`,...

Better. It needs a spec and a rubocop fix, see failed build.

Let's also add a comment in this code linking to the issue/conversation/something.

> @dblock could you move this pr in a separate branch, so I can try and fix your last requests, before this is ready to merge? You don't need me...

I think we should think about it backwards. Let's start with the right interfaces at the _model_ level first, then we can rethink where things go if they need to...

> Okay, that makes sense. Just thinking about what each model class represents, `activity_total`, `activity`, `explorer_segment`, `lap`, `route`, `segment`, and `split` could all have a `total_elevation_loss` property. And, all except...

@rramachand21 are you working on this?

> @imRishN Oh, haven't known that ,thanks for explanation! 👍 // It's that I assumed that given OpenSearch is a fork of Elasticsearch 7 version, it would have all the...

I support this. Should we move this to project-meta? Do we want the org to do this and create a label for every repo?

Good debugging @dbwiddis :) let’s see a fix?