Daniel (dB.) Doubrovkine comments

Results 3350 comments of


                                            Daniel (dB.) Doubrovkine

Faraday Timeouts no longer coming through as instance of Graphlient::Errors::FaradayServerError

https://github.com/slack-ruby/slack-ruby-client/pull/309

Docs incorrectly state that Graphlient::Errors::TimeoutError does not inherit from Graphlient::Errors::ServerError

This is by design I believe. A timeout is a client-side timeout, and you never got a response from the server (so no response or status code to be had)....

Docs incorrectly state that Graphlient::Errors::TimeoutError does not inherit from Graphlient::Errors::ServerError

For sure @PhucNguyen1501! I see the problem now, I didn't pay attention to the description. I edited the title of this issue and reopened it. Care to PR?

How to stub with webmock

> Where do I get this DummySchema In this project we have both client and server, but for a client app I think we need a better example. Generally, I...

Dynamically change headers

I believe right now this would require you to create a new instance of a client. We should call it a bug. I'd like to be able to do: ```ruby...

adding extensions to ExecutionError

Sounds like a good idea! PRs welcome.

adding extensions to ExecutionError

@RealSilo PRs always welcome!

Consider removing Faraday as a dependency and default to Net::HTTP

@papile Give upgrading Faraday in this gem a try? Looks fairly non-trivial.

Consider removing Faraday as a dependency and default to Net::HTTP

@papile We'll take anything that has all the specs passing :)

Add multipart request support

@pucinsk My biggest reservation about this PR is the creation of another adapter. Can we build multipart support into the existing one? What's the downside?