Daniel (dB.) Doubrovkine comments

Results 3350 comments of


                                            Daniel (dB.) Doubrovkine

Improve some documentation and start testing our documentation examples

This is great. Can we also have something publish the doc (versioned) on github gh-pages? Maybe part of the release or build?

Improve some documentation and start testing our documentation examples

I think we still want this @michaelherold. Need help?

Hashie::Extensions::DeepGrep

I like it. Would vote to merge if you can finish it with docs & al.

Hashie::Extensions::DeepGrep

LGTM, leaving final call(s) to @michaelherold, needs a README update, please

fixed issue in translating nested hash with multiple string keys

Awesome. - Add CHANGELOG please. - Is this going to work recursively, add a test with one more nested level of property. - There's some kind of problem in an...

fixed issue in translating nested hash with multiple string keys

Thanks for #520. Rebase?

fixed issue in translating nested hash with multiple string keys

Want to try and finish this @jitendra1998 ?

Property named required no longer works

According to https://github.com/intridea/hashie/commit/d03759fc876f8599ecf9b03e6095c26fd2aebe7e#commitcomment-10090931 this was fixed? @maxlinc?

Hashie::Extensions::IgnoreRequired mixin for ignoring required constraints

This is interesting. It undoes what a parent class mixes in, which is to enable these required validations. My first question was "why does someone need this?", then I read...

Hashie::Extensions::IgnoreRequired mixin for ignoring required constraints

I see, and I am now 80/20 :) I'd like to hear some other people's opinions about this, but in the meantime you should fix the specs, squash, update CHANGELOG,...