Daniel (dB.) Doubrovkine

icon indicating a website link https://code.dblock.org icon indicating an email [email protected]

icon company @opensearch-project icon location New York, NY icon location @opensearch-project, ex-@aws, former CTO @artsy @ArtsyOpenSource, @vestris, active maintainer of @ruby-grape, hashie, @slack-ruby, @playplayio and more.

Results 3350 comments of Daniel (dB.) Doubrovkine

Consider using keyword arguments and require Ruby 2.1

This code is generated from a template, so make a change in that and re-run an update. One giant PR will do.

Implement missing event handlers in the default Slack::RealTime::Stores::Store

Slack documents them here: https://api.slack.com/events. Maybe the README could use a link?

Implement missing event handlers in the default Slack::RealTime::Stores::Store

The internal event handling was refactored on HEAD, I've edited this issue to describe what I really want out of it (aka implement the missing event handlers in the default...

Warn that API endpoints are out-of-date

> Hi, I would like to work on this issue. Please do! Looking forward for PRs.

Make properties first class objects, support API types.

Started working on this in https://github.com/dblock/slack-ruby-client/tree/web-api-types, it currently generates types. The next step is to tie that together into the web API, so `channels.info` for example returns a Channel object...

Config option to prevent sending messages

For testing I feel like webmock does a better job. For real-time support it's trickier. Maybe writing an echo server that can run locally?

Unable to get Slack requests to pass data back to web app when clicking on message buttons

Without seeing the code a lot of things could be wrong. Does it reach your server? I would write a spec for your callback ala https://github.com/dblock/slack-market/blob/master/spec/api/endpoints/slack_endpoint_spec.rb to begin with.

By deprecating faye and celluloid you got rid of the websocket libraries that supported a proxy.

> What's preventing an upgrade to a more recent async-websocket? I tried a while ago and it didn't just work out of the box. Would love a PR. See #282

Duplicate messages in 'client.on :file_comment_added'

Have you opened a ticket with Slack on this? Looks like there's a notification with a timestamp and another one without, I am going to vote that this is as...

Duplicate messages in 'client.on :file_comment_added'

Yeah sorry I don't work for Slack. Reproducing it sounds like a good step forward.