slack-ruby-client icon indicating copy to clipboard operation
slack-ruby-client copied to clipboard

Consider using keyword arguments and require Ruby 2.1

Open mikz opened this issue 10 years ago • 4 comments

Ruby 2.1 has required keyword arguments, that could clean up a lot manual checking for existence of a key in options.

Would you consider requiring Ruby 2.1 ? I'd say it is not so strict requirement, given Rails 5 will require Ruby 2.2.

See 9174022 how it looks.

mikz avatar Nov 14 '15 15:11 mikz

I think it's a little too early for syntax sugar, but soon.

dblock avatar Nov 14 '15 22:11 dblock

We no longer support old rubies and could very well do this now.

dblock avatar May 07 '22 15:05 dblock

I'd consider working on this. This occurs quite often, however. https://github.com/slack-ruby/slack-ruby-client/search?q=throw+ArgumentError Do you want to review one giant PR with all of these?

duffn avatar Jun 10 '22 23:06 duffn

This code is generated from a template, so make a change in that and re-run an update. One giant PR will do.

dblock avatar Jun 11 '22 00:06 dblock