Daniel (dB.) Doubrovkine
Daniel (dB.) Doubrovkine
I think this change is good to merge as is. Other improvements like suggested above can be made later. Can you please fix CHANGELOG to make Danger happy?
Moved to sql repo.
Let's move this to SQL repo.
Mark this as ready when you're done and I'll re-CR carefully.
It's as simple as ad/delete(pop), but not very efficient.
Btw, we're now using slack-sup at Artsy, https://sup.playplay.io
Started https://github.com/dblock/open-weather-ruby-client/tree/history, but history is a $150 minimum paid API :(
Thanks for reporting it! Start by writing a unit test for both and let's see how we can fix it?
I am not sure. I think if the library can't convert something you'd probably want to get an error. At the very least that would be a change in behavior...
👍 give it a shot