strava-ruby-client icon indicating copy to clipboard operation
strava-ruby-client copied to clipboard
verified publisher icon dblock

Implements RateLimit for API Request/Response

Open simonneutert opened this issue 3 years ago • 2 comments

  • took off where Adam left
  • replaces https://github.com/dblock/strava-ruby-client/pull/50

TODO

  • [x] check variable naming (especially reponse/request)
  • [x] UPGRADING.md with hints to classes and their API that replaced the current state
  • [x] reread relevant parts of README.md
  • [x] maybe some more tests for pagination and the internal API of newly created classes
  • [x] hint on RaiseResponseError
  • [x] Namespaced inheritance for the models class Achievement < Strava::Models::Response to me that's a case when explicit beats implicit

simonneutert avatar Sep 19 '22 16:09 simonneutert

1 Warning
:warning: [DEPRECATION] check is deprecated. Please use check! instead.

Generated by :no_entry_sign: Danger

dangerpr-bot avatar Sep 19 '22 16:09 dangerpr-bot

Mark this as ready when you're done and I'll re-CR carefully.

dblock avatar Sep 23 '22 21:09 dblock

@dblock found the time to rebase, finally 😓

I will need some help with fixing dangerbot though.

simonneutert avatar Dec 27 '22 10:12 simonneutert

Thanks!

Did we mean to say fifteen_minute_ everywhere it says fiveteen_minute_? "Fifteen" is the correct spelling for 15.

The Danger TOC is complaining that you're missing the - [Strava::Api::Ratelimit public_methods](#stravaapiratelimit-public_methods) section. I would just say "The following properties are available on Strava::Api::Ratelimit and not make it a section. Also the way I typically fix the TOC is by copy-pasting the Danger output above on top of the TOC and making a new commit.

dblock avatar Dec 27 '22 15:12 dblock

https://github.com/dblock/strava-ruby-client/actions/runs/3789352784/jobs/6443023965

@dblock that typo might have haunted me all my life 🤯 please take a look on the failed action, too. cheers

simonneutert avatar Dec 27 '22 18:12 simonneutert

Grab the updated token from https://github.com/slack-ruby/slack-ruby-bot-server/pull/156/files

dblock avatar Dec 28 '22 17:12 dblock

Thanks for contributing this @simonneutert! Want to help co-maintain this library? Maybe make the next release? Email me your rubygems username to dblock at dblock dot org and I'll add you everywhere if you're up for it.

dblock avatar Dec 29 '22 03:12 dblock

We forgot to increment the version in version.rb to 1.0, please?

dblock avatar Dec 29 '22 03:12 dblock

@dblock I am very sorry for the faulty version, don't know why it slipped my mind and the search.

simonneutert avatar Dec 29 '22 09:12 simonneutert