Denis Blanchette
Denis Blanchette
Looking more into the code and testing, I realize `send_default_pii` controls whther to filter the Authorization header or not. It would be best to have a separate setting because we...
Thanks for the review! I made the requested changes.
@EnricoMi @ThomasJRyan Anything else I should do?
I went and look at all the files I changed to make sure there were no default values left in pyi. Crossing my fingers that everything is ok now 🤞
I hate to ask again, but is it all good? I'm looking forward to go back to using the official library instead of our fork. Thanks for your work maintaining...
@aaronn > I can't seem to get my .pem file loaded into the `app_private_key=MY_PRIVATE_KEY` field with `open(file).read()` nor just the filename. Is there something I'm missing? I'm not really sure...
> @dblanchette do you want some help with adding tests? I am also able to assist with fixing "Uses the first found installation for an app. This means that it...
@ammarmallik I merged your changes https://github.com/coveord/PyGithub/pull/28 and they are now integratred with this PR. I agree with requesting the installation id, even if it is one more call for our...
@rcoup Would you be the one to review it? We've been using this in production since I posted this PR in June 2021 and haven't got issues.
Should be fixed in version 0.48, let me know if not