dbeal
dbeal
can this PR be closed? the changes should be pushed to the `main` branch and be compatible with how the `main` subgraphs work.
this is still relevant.
> > If I'm forking off the wrong branch (ex. DefultStateManager rather than HardhatStateManager), please let me know, and I will rewrite my PR > > Yes, the `development` branch...
> Are those the failures you were talking about seeing on your local node? We'll definitely need to get those fixed. No, they were different failures, but definitely something wrong...
@feuGeneA if you could check this earlier this week that would be preferred, I will be limited availability starting next week. thanks :+1:
@alcuadrado @feuGeneA any update on this? sorry been on vacation the last couple weeks but would love to get this finalized if you have a chance. ty
@alcuadrado since your team seems busy with the change to the rust hardhat network, will withhold this until its done.
also in `Liquidation.js` we should probably some specific tests for `liquidationAmounts` verifying it returns expected amounts in edge cases like no liquidatable amount (aka positive c-ratio)
@aspiers can we get this merged? we ran into this issue today and its stopping us from using `--max-warnings=0` on our CI for some reason
so this is a practical issue that comes from providing this option in the first place. The only way (and even then it may not be enough). Therefore, when cannon...